LDP
/
man-pages
mirror of https://github.com/mkerrisk/man-pages
0
1
Fork 0
Code Releases Activity
361 Commits 1 Branch 197 Tags 93 MiB
Commit Graph

6 Commits

Author SHA1 Message Date
Michael Kerrisk 8c383102d0 hyphen/dash fixes 2005-07-07 08:27:03 +00:00
Michael Kerrisk 2bc2f4798f hyphen/dash fixes 2005-07-06 12:57:38 +00:00
Michael Kerrisk c65433e6a5 hyphen/dash fixes. 2005-07-06 08:00:30 +00:00
Michael Kerrisk f59a3f1941 Global edit: s/nonzero/non-zero/ 2005-06-15 13:32:34 +00:00
Michael Kerrisk 898e9a87df Hello Joey, 
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=205736

[[
This example contains the following line:

    if ((p = realloc (p, size)) == NULL)
       return NULL;

This is a very ill written code, since realloc returning
NULL do not deallocate the original memory block. Such a 
statement has a potential to become significant memory
hole. I suggest to correct this example since:

1. It may trick naive programmers to write bad code
2. It may lead skeptic observers to the believe 
   the whole Linux is written in a similar style.
   

Regards Jan Kuznik 
]]

This guy is right on the money!

I've changed that example, so that the above code has been replaced by:

    char *np;

    ...


    if ((np = realloc (p, size)) == NULL) {
        free(p);
        return NULL;
    } else {
        p = np;
    }

Cheers,

Michael
 2004-12-14 18:25:46 +00:00
Michael Kerrisk fea681dafb Import of man-pages 1.70 2004-11-03 13:51:07 +00:00