From ffc0ad65476a35eae06f87f22b7adb9242c8b1d9 Mon Sep 17 00:00:00 2001 From: "Martin A. Brown" Date: Wed, 17 Feb 2016 19:05:23 -0800 Subject: [PATCH] improve readability, parallelism of methods by inverting logic --- tldp/doctypes/linuxdoc.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tldp/doctypes/linuxdoc.py b/tldp/doctypes/linuxdoc.py index 391277d..67581a6 100644 --- a/tldp/doctypes/linuxdoc.py +++ b/tldp/doctypes/linuxdoc.py @@ -30,10 +30,10 @@ class Linuxdoc(BaseDoctype, SignatureChecker): logger.debug("%s creating TXT %s.", stem, outf) stdout = open(outf, 'wx') result = execute(cmd, logdir=logdir, stdout=stdout) - if result == 0: - logger.info("%s created TXT %s.", stem, outf) - return os.path.isfile(outf) - return False + if result != 0: + return False + logger.info("%s created TXT %s.", stem, outf) + return os.path.isfile(outf) def create_pdf(self): exe = self.platform.htmldoc @@ -46,10 +46,10 @@ class Linuxdoc(BaseDoctype, SignatureChecker): cmd = [exe, '--size', 'universal', '-t', 'pdf', '--firstpage', 'p1', '--outfile', outf, inf] result = execute(cmd, logdir=logdir) - if result == 0: - logger.info("%s created PDF %s.", stem, outf) - return os.path.isfile(outf) - return False + if result != 0: + return False + logger.info("%s created PDF %s.", stem, outf) + return os.path.isfile(outf) def create_html(self): exe = self.platform.sgml2html