LDP
/
man-pages
mirror of https://github.com/mkerrisk/man-pages
0
1
Fork 0
Code Releases Activity

core.5: Use adequate type 

'nread' is of type 'ssize_t'
'tot' adds up different values contained in 'nread',
so it should also be 'ssize_t', and not 'int' (which possibly overflows).

Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
This commit is contained in:
Alejandro Colomar 2020-09-10 23:13:39 +02:00 committed by Michael Kerrisk
parent b9bf902972
commit 95cc0897f7
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
man5/core.5
View File

@ -654,8 +654,7 @@ Total bytes in core dump: 282624
int
main(int argc, char *argv[])
{
int tot;
ssize_t nread;
ssize_t nread, tot;
char buf[BUF_SIZE];
FILE *fp;
char cwd[PATH_MAX];
@ -684,7 +683,7 @@ main(int argc, char *argv[])
tot = 0;
while ((nread = read(STDIN_FILENO, buf, BUF_SIZE)) > 0)
tot += nread;
fprintf(fp, "Total bytes in core dump: %d\en", tot);
fprintf(fp, "Total bytes in core dump: %zd\en", tot);
fclose(fp);
exit(EXIT_SUCCESS);