From 23509e5201c47eecfc4979970f7f75b0f810b164 Mon Sep 17 00:00:00 2001 From: Alexander Miller Date: Thu, 14 Apr 2016 01:13:04 +0200 Subject: [PATCH] Makefile: Don't leave $(GROFF_LOG) files behind Convert "GROFF_LOG" into a shell variable local to the recipe for "check-groff-warnings" target such that the temporary file is only created when needed. Acked-by: Mike Frysinger Signed-off-by: Alexander Miller Signed-off-by: Michael Kerrisk --- Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 237310da4..1003843ce 100644 --- a/Makefile +++ b/Makefile @@ -63,14 +63,14 @@ install: # Check if groff reports warnings (may be words of sentences not displayed) # from http://lintian.debian.org/tags/manpage-has-errors-from-man.html -GROFF_LOG := $(shell mktemp /tmp/manpages-checksXXXX) check-groff-warnings: + GROFF_LOG=$$(mktemp /tmp/manpages-checksXXXX); \ for i in man?/*.[1-9]; \ do \ if grep -q 'SH.*NAME' $$i; then \ - LC_ALL=en_US.UTF-8 MANWIDTH=80 man --warnings -E UTF-8 -l $$i > /dev/null 2>$(GROFF_LOG); \ - [ -s $(GROFF_LOG) ] && ( echo "$$i: " ; cat $(GROFF_LOG) ; echo "" ); \ - rm $(GROFF_LOG) 2>/dev/null; \ + LC_ALL=en_US.UTF-8 MANWIDTH=80 man --warnings -E UTF-8 -l $$i > /dev/null 2>$$GROFF_LOG; \ + [ -s $$GROFF_LOG ] && ( echo "$$i: " ; cat $$GROFF_LOG ; echo "" ); \ + rm $$GROFF_LOG 2>/dev/null; \ fi \ done